----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9173/#review16799 -----------------------------------------------------------
Ship it! Looks good to me (I'm not a committer). - Jarek Cecho On Jan. 31, 2013, 8:02 a.m., Mark Grover wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9173/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2013, 8:02 a.m.) > > > Review request for hive. > > > Description > ------- > > Add support for RegexSerde to support newly added Decimal type > > > This addresses bug HVIE-3951. > https://issues.apache.org/jira/browse/HVIE-3951 > > > Diffs > ----- > > ql/src/test/queries/clientpositive/serde_regex.q c3254ca > ql/src/test/results/clientpositive/serde_regex.q.out a933538 > serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java ae7693a > > Diff: https://reviews.apache.org/r/9173/diff/ > > > Testing > ------- > > Added a client positive test > > > Thanks, > > Mark Grover > >