[ https://issues.apache.org/jira/browse/HIVE-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588503#comment-13588503 ]
Arun A K commented on HIVE-3850: -------------------------------- Hello [~analog.sony], the test cases are ok. I think this need to be considered for commit. [~ajeshpg] had given me the link to raise the review request. I tried raising the review, but I am getting an error message "The selected file does not appear to be a diff." If possible could you create a new patch with the name HIVE-3850.1.patch ? Either [~710154] or yourself can do that so that we can edit the current review request (https://reviews.apache.org/r/9171/) or discard this and create a new one. > hour() function returns 12 hour clock value when using timestamp datatype > ------------------------------------------------------------------------- > > Key: HIVE-3850 > URL: https://issues.apache.org/jira/browse/HIVE-3850 > Project: Hive > Issue Type: Bug > Components: UDF > Affects Versions: 0.9.0, 0.10.0 > Reporter: Pieterjan Vriends > Fix For: 0.11.0 > > Attachments: hive-3850.patch, HIVE-3850.patch.txt > > > Apparently UDFHour.java does have two evaluate() functions. One that does > accept a Text object as parameter and one that does use a TimeStampWritable > object as parameter. The first function does return the value of > Calendar.HOUR_OF_DAY and the second one of Calendar.HOUR. In the > documentation I couldn't find any information on the overload of the > evaluation function. I did spent quite some time finding out why my statement > didn't return a 24 hour clock value. > Shouldn't both functions return the same? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira