[
https://issues.apache.org/jira/browse/HIVE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589076#comment-13589076
]
Phabricator commented on HIVE-4080:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-4080 [jira] Add Lead &
Lag UDAFs".
Mostly looks good.
* Missing apache headers.
* Request for couple more tests.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLead.java:1
Apache headers are missing.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLeadLag.java:1
Apache headers missing.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLag.java:1
Apache headers missing.
ql/src/test/queries/clientpositive/leadlag_queries.q:19 So, lead/lag can now
take three params. First one is column, second one is offset, third is default
value. Correct?
It will be good to have a test case with a constant default like lag
(price,5,10) and one with implicit params like lag (price) which implies
default of offset = 1 and NULL for default.
REVISION DETAIL
https://reviews.facebook.net/D8961
BRANCH
HIVE-4080
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, hbutani
> Add Lead & Lag UDAFs
> --------------------
>
> Key: HIVE-4080
> URL: https://issues.apache.org/jira/browse/HIVE-4080
> Project: Hive
> Issue Type: Bug
> Components: PTF-Windowing
> Reporter: Harish Butani
> Assignee: Harish Butani
> Attachments: HIVE-4080.1.patch.txt, HIVE-4080.D8961.1.patch,
> HIVE-4080.D8961.2.patch
>
>
> Currently we support Lead/Lag as navigation UDFs usable with Windowing.
> To be standard compliant we need to support Lead & Lag UDAFs.
> Will continue to support Lead/Lag UDFs as arguments to UDAFs when Windowing
> is in play.
> Currently allow Lead/Lag expressions to appear in SelectLists even when they
> are not arguments to UDAFs. Support for this feature will probably be
> removed. Causes ambiguities when Query contains different partition clauses.
> Will provide more details with associated Jira to remove this feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
