[
https://issues.apache.org/jira/browse/HIVE-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591449#comment-13591449
]
Mark Grover commented on HIVE-4053:
-----------------------------------
Krishna, thanks for doing this. I don't have a whole lot of insight into these
particular algorithms but do they always take the same parameters? What's the
possibility of a new phonetic algorithm using a different set or number of
parameters?
If these functions always take same parameters, it may make sense to do (2).
However, if not, (1) would be a good idea. Of course, you can still refactor
the code and share amongst all different UDFs even when they are separate.
To post a review on reviewboard, go to reviews.apache.org. Generate a diff file
of your changes on top of hive trunk (using svn diff or git diff) and upload
that diff (use "hive" repository when using svn diff output and hive-git
repository when using git diff output).
Please let me know if you have any further questions.
> Add support for phonetic algorithms in Hive
> -------------------------------------------
>
> Key: HIVE-4053
> URL: https://issues.apache.org/jira/browse/HIVE-4053
> Project: Hive
> Issue Type: New Feature
> Components: UDF
> Affects Versions: 0.10.0
> Reporter: Krishna
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: FunctionRegistry.java, GenericUDFRefinedSoundex.java,
> HIVE-4053.1.patch.txt
>
>
> Following phonetic algorithms should be considered, which are very useful in
> search:
> Soundex: http://en.wikipedia.org/wiki/Soundex
> Refined Soundex: Refer to the comment on 22/Feb/13 23:51
> Daitch–Mokotoff Soundex:
> http://en.wikipedia.org/wiki/Daitch%E2%80%93Mokotoff_Soundex
> Metaphone and Double Metaphone: http://en.wikipedia.org/wiki/Metaphone
> New York State Identification and Intelligence System (NYSIIS):
> http://en.wikipedia.org/wiki/New_York_State_Identification_and_Intelligence_System
> Caverphone: http://en.wikipedia.org/wiki/Caverphone
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
