[
https://issues.apache.org/jira/browse/HIVE-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4067:
------------------------------
Attachment: HIVE-4067.D8883.1.patch
sxyuan added you to the CC list for the revision "HIVE-4067 [jira] Followup to
HIVE-701: reduce ambiguity in grammar".
Reviewers: kevinwilfong
Make FROM, DISTINCT, PRESERVE, COLUMN, ALL, AND, OR, and NOT reserved keywords
(see comments for HIVE-701).
TEST PLAN
Run test queries.
REVISION DETAIL
https://reviews.facebook.net/D8883
AFFECTED FILES
ql/src/test/results/clientpositive/nonreserved_keywords_insert_into1.q.out
ql/src/test/results/compiler/errors/wrong_distinct2.q.out
ql/src/test/queries/clientpositive/nonreserved_keywords_insert_into1.q
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g
To: JIRA
> Followup to HIVE-701: reduce ambiguity in grammar
> -------------------------------------------------
>
> Key: HIVE-4067
> URL: https://issues.apache.org/jira/browse/HIVE-4067
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.11.0
> Reporter: Samuel Yuan
> Assignee: Samuel Yuan
> Priority: Minor
> Attachments: HIVE-4067.D8883.1.patch
>
>
> After HIVE-701 the grammar has become much more ambiguous, and the
> compilation generates a large number of warnings. Making FROM, DISTINCT,
> PRESERVE, COLUMN, ALL, AND, OR, and NOT reserved keywords again reduces the
> number of warnings to 134, up from the original 81 warnings but down from the
> 565 after HIVE-701. Most of the remaining ambiguity is trivial, an example
> being "KW_ELEM_TYPE | KW_KEY_TYPE | KW_VALUE_TYPE | identifier", and they are
> all correctly handled by ANTLR.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
