[
https://issues.apache.org/jira/browse/HIVE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599707#comment-13599707
]
Phabricator commented on HIVE-4108:
-----------------------------------
ashutoshc has accepted the revision "HIVE-4108 [jira] Allow over() clause to
contain an order by with no partition by".
+1
REVISION DETAIL
https://reviews.facebook.net/D9309
BRANCH
HIVE-4108
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, hbutani
> Allow over() clause to contain an order by with no partition by
> ---------------------------------------------------------------
>
> Key: HIVE-4108
> URL: https://issues.apache.org/jira/browse/HIVE-4108
> Project: Hive
> Issue Type: Bug
> Components: PTF-Windowing
> Reporter: Brock Noland
> Assignee: Harish Butani
> Attachments: HIVE-4108.D9309.1.patch
>
>
> HIVE-4073 allows over() to be called with no partition by and no order by. We
> should allow only an order by.
> From the review of HIVE-4073:
> Ashutosh
> {noformat}
> Can you also add following test. This should also work.
> select p_name, p_retailprice,
> avg(p_retailprice) over(order by p_name)
> from part
> partition by p_name;
> {noformat}
> Harish
> {noformat}
> This test will not work (:
> The grammar needs to be changed so:
> partitioningSpec
> @init { msgs.push("partitioningSpec clause"); }
> @after { msgs.pop(); }
> :
> partitionByClause orderByClause? -> ^(TOK_PARTITIONINGSPEC partitionByClause
> orderByClause?) |
> orderByClause -> ^(TOK_PARTITIONINGSPEC orderByClause) |
> distributeByClause sortByClause? -> ^(TOK_PARTITIONINGSPEC distributeByClause
> sortByClause?) |
> sortByClause? -> ^(TOK_PARTITIONINGSPEC sortByClause) |
> clusterByClause -> ^(TOK_PARTITIONINGSPEC clusterByClause)
> ;
> And the SemanticAnalyzer::processPTFPartitionSpec has to handle this shape of
> the AST Tree. The PTFTranslator also needs changes. Do this as another Jira
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
