[ https://issues.apache.org/jira/browse/HIVE-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601919#comment-13601919 ]
Phabricator commented on HIVE-4041: ----------------------------------- ashutoshc has commented on the revision "HIVE-4041 [jira] Support multiple partitionings in a single Query". First pass through patch. Some initial questions. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java:415 Why do we need to do this null check here ? ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java:425 Same question. ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java:482 This will set Order on all queries ? Consider query like sum(i) over (partition by si) ... this doesn't need an ordering, right ? ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java:212 Why do we need to change this function? REVISION DETAIL https://reviews.facebook.net/D9381 To: JIRA, ashutoshc, hbutani > Support multiple partitionings in a single Query > ------------------------------------------------ > > Key: HIVE-4041 > URL: https://issues.apache.org/jira/browse/HIVE-4041 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing > Reporter: Harish Butani > Assignee: Harish Butani > Attachments: HIVE-4041.D9381.1.patch, WindowingComponentization.pdf > > > Currently we disallow queries if the partition specifications of all Wdw fns > are not the same. We can relax this by generating multiple PTFOps based on > the unique partitionings in a Query. For partitionings that only differ in > sort, we can introduce a sort step in between PTFOps, which can happen in the > same Reduce task. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira