[
https://issues.apache.org/jira/browse/HIVE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616598#comment-13616598
]
Phabricator commented on HIVE-3464:
-----------------------------------
vikram has commented on the revision "HIVE-3464 [jira] Merging join tree may
reorder joins which could be invalid".
Comments.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinResolver.java:332
I am not sure these changes are relevant to this jira. There are already other
jiras - HIVE-3996 and HIVE-4071 raised for issues in this section of code and
currently blocked on HIVE-3891 which moves these changes into a different class.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinResolver.java:357
Same comment as above.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinResolver.java:369
Same as above.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinResolver.java:381
Same as above.
REVISION DETAIL
https://reviews.facebook.net/D5409
To: JIRA, navis
Cc: njain, vikram
> Merging join tree may reorder joins which could be invalid
> ----------------------------------------------------------
>
> Key: HIVE-3464
> URL: https://issues.apache.org/jira/browse/HIVE-3464
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Navis
> Assignee: Navis
> Attachments: HIVE-3464.D5409.2.patch, HIVE-3464.D5409.3.patch,
> HIVE-3464.D5409.4.patch, HIVE-3464.D5409.5.patch
>
>
> Currently, hive merges join tree from right to left regardless of join types,
> which may introduce join reordering. For example,
> select * from a join a b on a.key=b.key join a c on b.key=c.key join a d on
> a.key=d.key;
> Hive tries to merge join tree in a-d=b-d, a-d=a-b, b-c=a-b order and a-d=a-b
> and b-c=a-b will be merged. Final join tree is "a-(bdc)".
> With this, ab-d join will be executed prior to ab-c. But if join type of -c
> and -d is different, this is not valid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
