----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10280/#review18682 -----------------------------------------------------------
LGTM +1 (non-binding) - Prasad Mujumdar On April 4, 2013, 3:02 a.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10280/ > ----------------------------------------------------------- > > (Updated April 4, 2013, 3:02 a.m.) > > > Review request for hive. > > > Description > ------- > > HIVE-4292 - adding support for -hiveconf arg > > > Diffs > ----- > > service/src/java/org/apache/hive/service/server/HiveServer2.java d28890b > service/src/java/org/apache/hive/service/server/ServerOptionsProcessor.java > PRE-CREATION > > service/src/test/org/apache/hive/service/server/TestServerOptionsProcessor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10280/diff/ > > > Testing > ------- > > Unit test added. > > > Thanks, > > Thejas Nair > >
