[
https://issues.apache.org/jira/browse/HIVE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632200#comment-13632200
]
Travis Crawford commented on HIVE-4304:
---------------------------------------
[~ashutoshc] - I actually spent a bit of time Friday looking at this, and am
having issues getting tests to run. I'm hoping to look at this shortly, but if
you'd like to look at this sooner feel free to checkout the branch.
> Remove unused builtins and pdk submodules
> -----------------------------------------
>
> Key: HIVE-4304
> URL: https://issues.apache.org/jira/browse/HIVE-4304
> Project: Hive
> Issue Type: Improvement
> Reporter: Travis Crawford
> Assignee: Travis Crawford
> Attachments: HIVE-4304.1.patch
>
>
> Moving from email. The
> [builtins|http://svn.apache.org/repos/asf/hive/trunk/builtins/] and
> [pdk|http://svn.apache.org/repos/asf/hive/trunk/pdk/] submodules are not
> believed to be in use and should be removed. The main benefits are
> simplification and maintainability of the Hive code base.
> Forwarded conversation
> Subject: builtins submodule - is it still needed?
> ------------------------
> From: Travis Crawford <traviscrawf...@gmail.com>
> Date: Thu, Apr 4, 2013 at 2:01 PM
> To: u...@hive.apache.org, dev@hive.apache.org
> Hey hive gurus -
> Is the "builtins" hive submodule in use? The submodule was added in
> HIVE-2523 as a location for builtin-UDFs, but it appears to not have
> taken off. Any objections to removing it?
> DETAILS
> For HIVE-4278 I'm making some build changes for the HCatalog
> integration. The "builtins" submodule causes issues because it delays
> building until the packaging phase - so HCatalog can't depend on
> builtins, which it does transitively.
> While investigating a path forward I discovered the "builtins"
> submodule contains very little code, and likely could either go away
> entirely or merge into "ql", simplifying things both for users and
> developers.
> Thoughts? Can anyone with context help me understand "builtins", both
> in general and around its non-standard build? For your trouble I'll
> either make the submodule go away/merge into another submodule, or
> update the docs with what we learn.
> Thanks!
> Travis
> ----------
> From: Ashutosh Chauhan <ashutosh.chau...@gmail.com>
> Date: Fri, Apr 5, 2013 at 3:10 PM
> To: dev@hive.apache.org
> Cc: "u...@hive.apache.org" <u...@hive.apache.org>
> I haven't used it myself anytime till now. Neither have met anyone who used
> it or plan to use it.
> Ashutosh
> On Thu, Apr 4, 2013 at 2:01 PM, Travis Crawford
> <traviscrawf...@gmail.com>wrote:
> ----------
> From: Gunther Hagleitner <ghagleit...@hortonworks.com>
> Date: Fri, Apr 5, 2013 at 3:11 PM
> To: dev@hive.apache.org
> Cc: u...@hive.apache.org
> +1
> I would actually go a step further and propose to remove both PDK and
> builtins. I've went through the code for both and here is what I found:
> Builtins:
> - BuiltInUtils.java: Empty file
> - UDAFUnionMap: Merges maps. Doesn't seem to be useful by itself, but was
> intended as a building block for PDK
> PDK:
> - some helper build.xml/test setup + teardown scripts
> - Classes/annotations to help run unit tests
> - rot13 as an example
> From what I can tell it's a fair assessment that it hasn't taken off, last
> commits to it seem to have happened more than 1.5 years ago.
> Thanks,
> Gunther.
> On Thu, Apr 4, 2013 at 2:01 PM, Travis Crawford
> <traviscrawf...@gmail.com>wrote:
> ----------
> From: Owen O'Malley <omal...@apache.org>
> Date: Fri, Apr 5, 2013 at 4:45 PM
> To: u...@hive.apache.org
> +1 to removing them.
> We have a Rot13 example in
> ql/src/test/org/apache/hadoop/hive/ql/io/udf/Rot13{In,Out}putFormat.java
> anyways. *smile*
> -- Owen
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
