[ 
https://issues.apache.org/jira/browse/HIVE-3846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641875#comment-13641875
 ] 

Ashutosh Chauhan commented on HIVE-3846:
----------------------------------------

Few comments:
* I think you forgot to add .q.out file in your patch.
* In the .q testcase, can you add set 
{{hive.security.authorization.enabled=false;}} at the end. Otherwise, 
authorization will be on for rest of the tests as well.
* Test TestCliDriver.alter_view_rename.q and 
TestNegativeCliDriver.recursive_view.q fails after patch. There .q.out file 
needs to be updated.
                
> alter view rename NPEs with authorization on.
> ---------------------------------------------
>
>                 Key: HIVE-3846
>                 URL: https://issues.apache.org/jira/browse/HIVE-3846
>             Project: Hive
>          Issue Type: Bug
>          Components: Authorization
>    Affects Versions: 0.10.0, 0.11.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Teddy Choi
>         Attachments: HIVE-3846.1.patch.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to