----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10757/#review19713 -----------------------------------------------------------
branches/branch-0.11/service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java <https://reviews.apache.org/r/10757/#comment40652> Missing space: "for(" branches/branch-0.11/service/src/test/org/apache/hive/service/cli/operation/TestCloseOperations.java <https://reviews.apache.org/r/10757/#comment40653> It seems like this is a test of HiveSession functionality. Please change the name to TestHiveSession and move it to the package o.a.h.service.cli.session. - Carl Steinbach On April 25, 2013, 4:06 p.m., Ashish Vaidya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10757/ > ----------------------------------------------------------- > > (Updated April 25, 2013, 4:06 p.m.) > > > Review request for hive, Ashutosh Chauhan and Thejas Nair. > > > Description > ------- > > > Addressing latest comments from Thejas. This keeps OperationManager.java > unchanged. > > > This addresses bug HIVE-4398. > https://issues.apache.org/jira/browse/HIVE-4398 > > > Diffs > ----- > > > branches/branch-0.11/service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 1475834 > > branches/branch-0.11/service/src/test/org/apache/hive/service/cli/operation/TestCloseOperations.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10757/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Vaidya > >
