[
https://issues.apache.org/jira/browse/HIVE-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4427:
------------------------------
Attachment: HIVE-4427.D10599.1.patch
Mrrrgn requested code review of "HIVE-4427 [jira] SemanticAnalyzer throws
OFFLINE_TABLE_OR_PARTITION exceptions with null context.".
Reviewers: JIRA
Removed unnecessary table.isOffline check happening outside of
SemanticAnalyzer.validate() to fix null hook contexts and allow custom offline
error messages (via hooks) at a partition level.
In SemanticAnalyzer offline tables throw a SemanticException before validate()
is called. This is unnecessary, since all appropriate checks are run within
the validate method, and is a bug because it throws exceptions with a null
context (preventing custom offline error messages via hooks).
TEST PLAN
Modified a SemanticAnalyzerHook to dump the line number or
SemanticAnalyazer.java where an Exception was thrown. When calling an offline
partition in an offline table, before my changes, exceptions were thrown
outside of the validate() method. After my changes exceptions were thrown from
within
the validate method. To further verify that the exceptions were correct, I
dumped the error message and context to verfity that the exception messages
were of type OFFLINE_TABLE_OR_PARTITION and that the HookContext was not null.
After my changes proper errors were indeed thrown, with appropriate contexts.
REVISION DETAIL
https://reviews.facebook.net/D10599
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/25359/
To: JIRA, Mrrrgn
> SemanticAnalyzer throws OFFLINE_TABLE_OR_PARTITION exceptions with null
> context.
> --------------------------------------------------------------------------------
>
> Key: HIVE-4427
> URL: https://issues.apache.org/jira/browse/HIVE-4427
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Morgan Phillips
> Assignee: Morgan Phillips
> Priority: Minor
> Attachments: HIVE-4427.D10599.1.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> In SemanticAnalyzer offline tables throw a SemanticException before
> validate() is called. This is unnecessary, since all appropriate checks are
> run within the validate method, and is a bug because it throws exceptions
> with a null context (preventing custom offline error messages via hooks).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
