[ 
https://issues.apache.org/jira/browse/HIVE-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646918#comment-13646918
 ] 

Shuaishuai Nie commented on HIVE-4469:
--------------------------------------

The idea is to separate the logic for execute command only for the “diff” when 
comparing the test result on Windows. In this case, the execution of other 
command will not be affected and the logic for Linux remain the same. When 
running the “diff” command on Windows, the output of “diff” will be filtered by 
a set of pattern, and if all the output lines of “diff” fit the patterns, the 
return value of the execution of “diff” will set to normal instead of 
error.(the patterns are a set of regular expression which match the know output 
inconsistency between Windows and Linux) Also the output of the “diff” will 
still be printed to the output and log just in case. The advantage of the 
method is it provide a way to ignore any know inconsistency between the output 
of Windows and Linux. By adding patterns in the filter, similar problems in the 
future can be solved in the same way.
                
> Tests in TestCliDriver fail on Windows caused by hard coded file size in 
> .q.out file
> ------------------------------------------------------------------------------------
>
>                 Key: HIVE-4469
>                 URL: https://issues.apache.org/jira/browse/HIVE-4469
>             Project: Hive
>          Issue Type: Bug
>          Components: Testing Infrastructure
>    Affects Versions: 0.11.0
>         Environment: Windows
>            Reporter: Shuaishuai Nie
>            Assignee: Shuaishuai Nie
>         Attachments: HIVE-4469.1.patch
>
>
> Several tests in TestCliDriver fail on Windows caused by hard coded file size 
> in .q.out file. The reason is the newline character is different in Windows 
> and Linux which cause the query result file has different file size and the 
> test result on windows does not match expected result in .q.out file

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to