[
https://issues.apache.org/jira/browse/HIVE-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650287#comment-13650287
]
Phabricator commented on HIVE-4427:
-----------------------------------
kevinwilfong has commented on the revision "HIVE-4427 [jira] SemanticAnalyzer
throws OFFLINE_TABLE_OR_PARTITION exceptions with null context.".
It looks like the revision that added this code did not add a proper testcase
for it, based on what the comments say it's trying to achieve.
http://svn.apache.org/viewvc?view=revision&revision=982476
Could you add a testcase where you attempt to select from an offline table
with no partitions or where all partitions are filtered and verify it fails
rather than returning no results?
REVISION DETAIL
https://reviews.facebook.net/D10599
To: JIRA, kevinwilfong, sindheeraj, Mrrrgn
> SemanticAnalyzer throws OFFLINE_TABLE_OR_PARTITION exceptions with null
> context.
> --------------------------------------------------------------------------------
>
> Key: HIVE-4427
> URL: https://issues.apache.org/jira/browse/HIVE-4427
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Morgan Phillips
> Assignee: Morgan Phillips
> Priority: Minor
> Attachments: HIVE-4427.D10599.1.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> In SemanticAnalyzer offline tables throw a SemanticException before
> validate() is called. This is unnecessary, since all appropriate checks are
> run within the validate method, and is a bug because it throws exceptions
> with a null context (preventing custom offline error messages via hooks).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
