[
https://issues.apache.org/jira/browse/HIVE-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4525:
------------------------------
Attachment: D10755.1.patch
mbautin requested code review of "[jira] [HIVE-4525] Support timestamps earlier
than 1970 and later than 2038".
Reviewers: JIRA, ashutoshc, sdong, cwsteinbach, omalley
TimestampWritable currently serializes timestamps using the lower 31 bits of an
int. This does not allow to store timestamps earlier than 1970 or later than
approximately 03:14:07 UTC on 01/19/2038. This patch modifies TimestampWritable
to support all timestamps that can be represented by java.sql.Timestamp.
TEST PLAN
- An extensive new TimestampWritable unit test
- Existing unit tests
REVISION DETAIL
https://reviews.facebook.net/D10755
AFFECTED FILES
hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerFactory.java
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
serde/src/test/org/apache/hadoop/hive/serde2/io/TestTimestampWritable.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/25737/
To: JIRA, ashutoshc, sdong, cwsteinbach, omalley, mbautin
> Support timestamps earlier than 1970 and later than 2038
> --------------------------------------------------------
>
> Key: HIVE-4525
> URL: https://issues.apache.org/jira/browse/HIVE-4525
> Project: Hive
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D10755.1.patch
>
>
> TimestampWritable currently serializes timestamps using the lower 31 bits of
> an int. This does not allow to store timestamps earlier than 1970 or later
> than a certain point in 2038.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
