-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11029/
-----------------------------------------------------------
(Updated May 13, 2013, 9:51 p.m.)
Review request for hive.
Changes
-------
Changes in new patch -
add @Override to interface functions being implemented in HiveHistoryImpl
Removing javadoc duplication in HiveHistoryImpl. It will automatically inherit
the documentation from interface.
Logging the exception in code unrelated to patch, to partly address Brock's
concern. Since the code is not part of the patch, I don't want to increase the
scope to address that concern.
Description
-------
HIVE-4513
This addresses bug HIVE-4513.
https://issues.apache.org/jira/browse/HIVE-4513
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1672453
conf/hive-default.xml.template 3a7d1dc
data/conf/hive-site.xml 544ba35
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java e1c1ae3
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryProxyHandler.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryUtil.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryViewer.java fdd56db
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 3d43451
ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java a783303
Diff: https://reviews.apache.org/r/11029/diff/
Testing
-------
Thanks,
Thejas Nair
