[ 
https://issues.apache.org/jira/browse/HIVE-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665934#comment-13665934
 ] 

Eric Hanson commented on HIVE-4592:
-----------------------------------

Completed review and update of Col-Col, Col-Scalar, and Scalar-Col arithmetic 
templates. Verified isRepeating and noNulls propagation from input(s)to output 
column. Made sure that NULL values have their data entry set properly in the 
output data vector as well, based on the spec (1 for long, NaN for double).
                
> ColumnArithmeticColumn.txt template never sets output isNull to true; can 
> give wrong results
> --------------------------------------------------------------------------------------------
>
>                 Key: HIVE-4592
>                 URL: https://issues.apache.org/jira/browse/HIVE-4592
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: vectorization-branch
>            Reporter: Eric Hanson
>            Assignee: Eric Hanson
>             Fix For: vectorization-branch
>
>         Attachments: HIVE-4592.1.patch
>
>
> ColumnArithmeticColumn.txt should set the output column's noNulls flag to 
> true if neither input column has nulls, but it does not do that. This can 
> lead to wrong results is the noNulls was set to false in a previous use of 
> the batch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to