----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11530/ -----------------------------------------------------------
(Updated May 31, 2013, 1:59 p.m.) Review request for hive, Jitendra Pandey and Eric Hanson. Changes ------- Update patch to the review comments in https://reviews.apache.org/r/11530/ Description ------- Timestamp UDFs for vectorized long nanosecond timestamps - all of them convert timestamp into a corresponding long/int value (year, month, week-of-year, day-of-month, hour, minute, second, unix-timestamp). This addresses bug HIVE-4608. https://issues.apache.org/jira/browse/HIVE-4608 Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDayOfMonthLong.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFHourLong.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFMinuteLong.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFMonthLong.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFSecondLong.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFTimestampFieldLong.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFUnixTimeStampLong.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFWeekOfYearLong.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFYearLong.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTimestampExpressions.java PRE-CREATION Diff: https://reviews.apache.org/r/11530/diff/ Testing ------- Unit tests included which compare each UDF against its non-vectorized one's output, with random data and year boundary data (+1,0,-1). Thanks, Gopal V
