[
https://issues.apache.org/jira/browse/HIVE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675654#comment-13675654
]
Hudson commented on HIVE-4377:
------------------------------
Integrated in Hive-trunk-h0.21 #2128 (See
[https://builds.apache.org/job/Hive-trunk-h0.21/2128/])
HIVE-4377 : Add more comment to https://reviews.facebook.net/D1209
(HIVE2340) : (Navis via Ashutosh Chauhan) (Revision 1489436)
Result = FAILURE
hashutosh :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1489436
Files :
* /hive/trunk/hcatalog/build.xml
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java
* /hive/trunk/ql/src/test/queries/clientpositive/reduce_deduplicate_extended.q
*
/hive/trunk/ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out
> Add more comment to https://reviews.facebook.net/D1209 (HIVE-2340)
> ------------------------------------------------------------------
>
> Key: HIVE-4377
> URL: https://issues.apache.org/jira/browse/HIVE-4377
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Gang Tim Liu
> Assignee: Navis
> Fix For: 0.12.0
>
> Attachments: HIVE-4377.D10377.1.patch, HIVE-4377.D10377.2.patch,
> HIVE-4377.D10377.3.patch
>
>
> thanks a lot for addressing optimization in HIVE-2340. Awesome!
> Since we are developing at a very fast pace, it would be really useful to
> think about maintainability and testing of the large codebase. Highlights
> which are applicable for D1209:
> 1. Javadoc for all public/private functions, except for
> setters/getters. For any complex function, clear examples (input/output)
> would really help.
> 2. Specially, for query optimizations, it might be a good idea to have
> a simple working query at the top, and the expected changes. For e.g..
> The operator tree for that query at each step, or a detailed explanation
> at the top.
> 3. If possible, the test name (.q file) where the function is being
> invoked, or the query which would potentially test that scenario, if it
> is a query processor change.
> 4. Comments in each test (.q file) that should include the jira
> number, what is it trying to test. Assumptions about each query.
> 5. Reduce the output for each test whenever query is outputting more
> than 10 results, it should have a reason. Otherwise, each query result
> should be bounded by 10 rows.
> thanks a lot
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
