[ 
https://issues.apache.org/jira/browse/HIVE-4692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-4692:
------------------------------

    Attachment: HIVE-4692.D11169.1.patch

navis requested code review of "HIVE-4692 [jira] Constant agg parameters will 
be replaced by ExprNodeColumnDesc with single-sourced multi-gby cases".

Reviewers: JIRA

HIVE-4692 Constant agg parameters will be replaced by ExprNodeColumnDesc with 
single-sourced multi-gby cases

HIVE-3495 fixed this for single gbys but not for multi-gbys. For example,

FROM (select key, cast(key as double) as value from src order by key) a
INSERT OVERWRITE TABLE e1
    SELECT COUNT(*)
INSERT OVERWRITE TABLE e2
    SELECT percentile_approx(value, 0.5);

FAILED: UDFArgumentTypeException The second argument must be a constant, but 
double was passed instead.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D11169

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
  ql/src/test/queries/clientpositive/multi_insert_gby2.q
  ql/src/test/results/clientpositive/multi_insert_gby2.q.out

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/26607/

To: JIRA, navis

                
> Constant agg parameters will be replaced by ExprNodeColumnDesc with 
> single-sourced multi-gby cases
> --------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-4692
>                 URL: https://issues.apache.org/jira/browse/HIVE-4692
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-4692.D11169.1.patch
>
>
> HIVE-3495 fixed this for single gbys but not for multi-gbys. For example,
>  
> {noformat}
> FROM (select key, cast(key as double) as value from src order by key) a
> INSERT OVERWRITE TABLE e1
>     SELECT COUNT(*)
> INSERT OVERWRITE TABLE e2
>     SELECT percentile_approx(value, 0.5);
> FAILED: UDFArgumentTypeException The second argument must be a constant, but 
> double was passed instead.
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to