[ 
https://issues.apache.org/jira/browse/HIVE-4709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-4709:
------------------------------

    Attachment: HIVE-4709.D11199.1.patch

navis requested code review of "HIVE-4709 [jira] Caching OIs in OIFactory 
should be disabled".

Reviewers: JIRA

HIVE-4709 Caching OIs in OIFactory should be disabled

OIFactory has various caches and most of them are accessed by key containing 
OIs. But OIs are not forced to implement hashCode/equals and that is resulted 
to some kind of memory leakage.

Considering the price of calculating/accessing hashmap, just removing those 
caches are better solution, IMHO.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D11199

AFFECTED FILES
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/26679/

To: JIRA, navis

                
> Caching OIs in OIFactory should be disabled
> -------------------------------------------
>
>                 Key: HIVE-4709
>                 URL: https://issues.apache.org/jira/browse/HIVE-4709
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>         Attachments: HIVE-4709.D11199.1.patch
>
>
> OIFactory has various caches and most of them are accessed by key containing 
> OIs. But OIs are not forced to implement hashCode/equals and that is resulted 
> to some kind of memory leakage. 
> Considering the price of calculating/accessing hashmap, just removing those 
> caches are better solution, IMHO.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to