----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11857/ -----------------------------------------------------------
Review request for hive, Jitendra Pandey and Eric Hanson. Description ------- `stringIndices[i]= stringIndicesIndex` should be `stringIndices[stringIndicesIndex]= i`. D'oh! the second issue fixed (wrong isNull index used in cloning) was uncovered in testing the fix This addresses bug HIVE-4716. https://issues.apache.org/jira/browse/HIVE-4716 Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java 70e3cfd ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapperBatch.java 669946d Diff: https://reviews.apache.org/r/11857/diff/ Testing ------- repro case tested Thanks, Remus Rusanu