[ 
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-4579:
------------------------------

    Attachment: HIVE-4579.D11409.1.patch

omalley requested code review of "HIVE-4579 [jira] Create a SARG interface for 
RecordReaders".

Reviewers: JIRA

HIVE-4579 Create SARG interface

I think we should create a SARG (http://en.wikipedia.org/wiki/Sargable) 
interface for RecordReaders. For a first pass, I'll create an API that uses the 
value stored in hive.io.filter.expr.serialized.

The desire is to define an simpler interface that the direct AST expression 
that is provided by hive.io.filter.expr.serialized so that the code to evaluate 
expressions can be generalized instead of put inside a particular RecordReader.

TEST PLAN
  added unit test

REVISION DETAIL
  https://reviews.facebook.net/D11409

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java
  ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java
  ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
  ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/27069/

To: JIRA, omalley

                
> Create a SARG interface for RecordReaders
> -----------------------------------------
>
>                 Key: HIVE-4579
>                 URL: https://issues.apache.org/jira/browse/HIVE-4579
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: h-4579.patch, HIVE-4579.D11409.1.patch, pushdown.pdf
>
>
> I think we should create a SARG (http://en.wikipedia.org/wiki/Sargable) 
> interface for RecordReaders. For a first pass, I'll create an API that uses 
> the value stored in hive.io.filter.expr.serialized.
> The desire is to define an simpler interface that the direct AST expression 
> that is provided by hive.io.filter.expr.serialized so that the code to 
> evaluate expressions can be generalized instead of put inside a particular 
> RecordReader.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to