[ 
https://issues.apache.org/jira/browse/HIVE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691335#comment-13691335
 ] 

Edward Capriolo commented on HIVE-1402:
---------------------------------------

Navis. Nice work all tests pass. One thing I noticed.

{quote}
        for (FileStatus status : fs.globStatus(new Path(inputPath, 
".sampling*"))) {
+          sampler.addSampleFile(status.getPath(), job);
+        }
{quote}

For hadoop hidden files by convention start with '_' not '.' . Does it make 
sense to say "_sampling*" here. Possibly put this as a constant at the top of 
the file.

So please fix the above thing if you think it is a good idea, and regenerate 
the patch so it applies clean please.

Then I will commit.
                
> Add parallel ORDER BY to Hive
> -----------------------------
>
>                 Key: HIVE-1402
>                 URL: https://issues.apache.org/jira/browse/HIVE-1402
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Jeff Hammerbacher
>            Assignee: Navis
>              Labels: optimization
>         Attachments: HIVE-1402.1.patch.txt, HIVE-1402.D8895.1.patch, 
> HIVE-1402.D8895.2.patch, HIVE-1402.D8895.3.patch, HIVE-1402.D8895.4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to