[
https://issues.apache.org/jira/browse/HIVE-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693010#comment-13693010
]
Phabricator commented on HIVE-4719:
-----------------------------------
brock has commented on the revision "HIVE-4719 [jira] EmbeddedLockManager
should be shared to all clients".
Hi Navis,
Thank you very much for the patch! Once again, I am newish to this code so
my comments might not be applicable. However, I do have a question below in
the case when a lockFactory and lockManager cannot be created. I did note some
very minor nits as well.
Cheers!
Brock
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:143 It seems that if
newInstance throws an exception than the member variable lockFactory will be
null. When lockFactory is null createLockManager will return null. Then the
member variable of Context, hiveLockMgr, will be null. In this case
isLockRequired will always return false. I think that is a concern when locking
is required?
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:153 When
lockFactory.create() throws an exception, createLockManager will return null.
Then the member variable of Context, hiveLockMgr, will be null. In this case
isLockRequired will always return false. I think that is a concern when locking
is required?
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DefaultLockFactory.java:40 nit:
missing @Override
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DefaultLockFactory.java:31 nit:
missing @Override
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockFactory.java:44
nit: missing @Override
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockFactory.java:48
nit: missing @Override
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockFactory.java:58
nit: missing @Override
REVISION DETAIL
https://reviews.facebook.net/D11229
To: JIRA, navis
Cc: brock
> EmbeddedLockManager should be shared to all clients
> ---------------------------------------------------
>
> Key: HIVE-4719
> URL: https://issues.apache.org/jira/browse/HIVE-4719
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: HIVE-4719.D11229.1.patch, HIVE-4719.D11229.2.patch
>
>
> Currently, EmbeddedLockManager is created per Driver instance, so locking has
> no meaning.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
