[ 
https://issues.apache.org/jira/browse/HIVE-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-4055:
------------------------------

    Attachment: HIVE-4055.D11547.1.patch

jdere requested code review of "HIVE-4055 [jira] add Date data type".

Reviewers: JIRA

Add Date data type, a new primitive data type which supports the standard SQL 
date type.

Basically, the implementation can take HIVE-2272 and HIVE-2957 as references.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D11547

AFFECTED FILES
  data/files/datatypes.txt
  data/files/flights_join.txt
  data/files/flights_tiny.txt.1
  jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
  jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
  jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java
  jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java
  jdbc/src/java/org/apache/hadoop/hive/jdbc/Utils.java
  jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java
  jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java
  jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java
  jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java
  jdbc/src/java/org/apache/hive/jdbc/Utils.java
  jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java
  jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java
  ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java
  ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/DateColumnStatistics.java
  
serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/MyTestClassSmaller.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMonth.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnixTimeStamp.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFWeekOfYear.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFYear.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFContextNGrams.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCorrelation.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovariance.java
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovarianceSample.java
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStd.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStdSample.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVarianceSample.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFnGrams.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUnixTimeStamp.java
  ql/src/protobuf/org/apache/hadoop/hive/ql/io/orc/orc_proto.proto
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java
  ql/src/test/queries/clientnegative/invalid_t_alter1.q
  ql/src/test/queries/clientnegative/invalid_t_alter2.q
  ql/src/test/queries/clientnegative/invalid_t_create1.q
  ql/src/test/queries/clientnegative/invalid_t_transform.q
  ql/src/test/queries/clientpositive/ctas_date.q
  ql/src/test/queries/clientpositive/date_1.q
  ql/src/test/queries/clientpositive/date_2.q
  ql/src/test/queries/clientpositive/date_3.q
  ql/src/test/queries/clientpositive/date_4.q
  ql/src/test/queries/clientpositive/date_comparison.q
  ql/src/test/queries/clientpositive/date_join1.q
  ql/src/test/queries/clientpositive/date_serde.q
  ql/src/test/queries/clientpositive/date_udf.q
  ql/src/test/queries/clientpositive/partition_date.q
  ql/src/test/queries/clientpositive/union_date.q
  ql/src/test/results/clientnegative/invalid_create_tbl1.q.out
  ql/src/test/results/clientnegative/invalid_t_alter1.q.out
  ql/src/test/results/clientnegative/invalid_t_alter2.q.out
  ql/src/test/results/clientnegative/invalid_t_create1.q.out
  ql/src/test/results/clientnegative/invalid_t_create2.q.out
  ql/src/test/results/clientnegative/invalid_t_transform.q.out
  ql/src/test/results/clientpositive/ctas_date.q.out
  ql/src/test/results/clientpositive/date_1.q.out
  ql/src/test/results/clientpositive/date_2.q.out
  ql/src/test/results/clientpositive/date_3.q.out
  ql/src/test/results/clientpositive/date_4.q.out
  ql/src/test/results/clientpositive/date_comparison.q.out
  ql/src/test/results/clientpositive/date_join1.q.out
  ql/src/test/results/clientpositive/date_serde.q.out
  ql/src/test/results/clientpositive/date_udf.q.out
  ql/src/test/results/clientpositive/partition_date.q.out
  ql/src/test/results/clientpositive/union_date.q.out
  serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java
  serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
  
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
  serde/src/java/org/apache/hadoop/hive/serde2/io/DateWritable.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyDate.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyDateObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryDate.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/DateObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaDateObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableDateObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantDateObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableDateObjectInspector.java
  serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
  serde/src/test/org/apache/hadoop/hive/serde2/TestStatsSerde.java
  serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/MyTestClass.java
  
serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java
  serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/MyTestClassBigger.java
  
serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/TestLazyBinarySerDe.java
  service/README.txt
  service/if/TCLIService.thrift
  service/src/gen/thrift/gen-cpp/TCLIService_constants.cpp
  service/src/gen/thrift/gen-cpp/TCLIService_types.cpp
  service/src/gen/thrift/gen-cpp/TCLIService_types.h
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIServiceConstants.java
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeId.java
  service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote
  service/src/gen/thrift/gen-py/TCLIService/constants.py
  service/src/gen/thrift/gen-py/TCLIService/ttypes.py
  service/src/gen/thrift/gen-rb/t_c_l_i_service_constants.rb
  service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb
  service/src/java/org/apache/hive/service/cli/ColumnValue.java
  service/src/java/org/apache/hive/service/cli/Type.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/27315/

To: JIRA, jdere

                
> add Date data type
> ------------------
>
>                 Key: HIVE-4055
>                 URL: https://issues.apache.org/jira/browse/HIVE-4055
>             Project: Hive
>          Issue Type: Sub-task
>          Components: JDBC, Query Processor, Serializers/Deserializers, UDF
>            Reporter: Sun Rui
>         Attachments: Date.pdf, HIVE-4055.1.patch.txt, HIVE-4055.2.patch.txt, 
> HIVE-4055.D11547.1.patch
>
>
> Add Date data type, a new primitive data type which supports the standard SQL 
> date type.
> Basically, the implementation can take HIVE-2272 and HIVE-2957 as references.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to