[
https://issues.apache.org/jira/browse/HIVE-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716449#comment-13716449
]
Ashutosh Chauhan commented on HIVE-4864:
----------------------------------------
[~chenghao] Can you put these comment in Description annotation (see other udfs
for example) that way it will show up to users when they do describe on these
udfs.
> Code Comments seems confused between GenericUDFCase & GenericUDFWhen
> --------------------------------------------------------------------
>
> Key: HIVE-4864
> URL: https://issues.apache.org/jira/browse/HIVE-4864
> Project: Hive
> Issue Type: Task
> Affects Versions: 0.9.0
> Reporter: Cheng Hao
> Priority: Trivial
> Attachments: 1.patch
>
>
> Code Comment in GenericUDFCase:
> /**
> * GenericUDF Class for SQL construct
> * "CASE WHEN a THEN b WHEN c THEN d [ELSE f] END".
> *
> * NOTES: 1. a and c should be boolean, or an exception will be thrown. 2. b, d
> * and f should have the same TypeInfo, or an exception will be thrown.
> */
> And the code comment in GenericUDFWhen:
> /**
> * GenericUDF Class for SQL construct "CASE a WHEN b THEN c [ELSE f] END".
> *
> * NOTES: 1. a and b should have the same TypeInfo, or an exception will be
> thrown. 2. c and f should have the same TypeInfo, or an exception will be
> * thrown.
> */
> From the code itself, seems the comments should be exchanged. We'd better
> amend that to avoid confusing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
