Can i get some +1 love ? I have 2 or 3 follow ons.
On Tuesday, July 30, 2013, Hive QA (JIRA) <j...@apache.org> wrote: > > [ https://issues.apache.org/jira/browse/HIVE-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724561#comment-13724561] > > Hive QA commented on HIVE-4954: > ------------------------------- > > > > {color:green}Overall{color}: +1 all checks pass > > Here are the results of testing the latest attachment: > https://issues.apache.org/jira/secure/attachment/12595032/HIVE-4879.2.patch.txt > > {color:green}SUCCESS:{color} +1 2749 tests passed > > Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/248/testReport > Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/248/console > > Messages: > {noformat} > Executing org.apache.hive.ptest.execution.PrepPhase > Executing org.apache.hive.ptest.execution.ExecutionPhase > Executing org.apache.hive.ptest.execution.ReportingPhase > {noformat} > > This message is automatically generated. > >> PTFTranslator hardcodes ranking functions >> ----------------------------------------- >> >> Key: HIVE-4954 >> URL: https://issues.apache.org/jira/browse/HIVE-4954 >> Project: Hive >> Issue Type: Improvement >> Reporter: Edward Capriolo >> Assignee: Edward Capriolo >> Attachments: HIVE-4879.2.patch.txt, HIVE-4954.1.patch.txt >> >> >> protected static final ArrayList<String> RANKING_FUNCS = new ArrayList<String>(); >> static { >> RANKING_FUNCS.add("rank"); >> RANKING_FUNCS.add("dense_rank"); >> RANKING_FUNCS.add("percent_rank"); >> RANKING_FUNCS.add("cume_dist"); >> }; >> Move this logic to annotations > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira >
