[
https://issues.apache.org/jira/browse/HIVE-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4985:
------------------------------
Attachment: HIVE-4985.D11961.1.patch
sershe requested code review of "HIVE-4985 [jira] refactor/clean up partition
name pruning to be usable inside metastore server".
Reviewers: JIRA
This patch contains 3 main changes.
1) Minor cleanup to move some common exception handling into a method.
2) Clean up filtered partition result type to remove unused features (denied
list, separate unknown list - only one list is always used, and only boolean
checks are done on unknown lists, replace sets with lists as they do not appear
to be used in a manner that would benefit from set usage).
3) Corresponding cleanup of pruning code, and moving the name-filtering code
into separate method (which will later be used from the server as opposed to
client.)
4) Removal of the dead code pertaining to RowObjectInspector there.
I am running tests, many passed so far.
Preliminary for HIVE-4914.
The patch is going to be large already, so some refactoring and dead code
removal that is non-controversial can be done in advance in a separate patch.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D11961
AFFECTED FILES
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
ql/src/java/org/apache/hadoop/hive/ql/Driver.java
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java
ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/AvgPartitionSizeBasedBigTableSelectorForAutoSMJ.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GlobalLimitOptimizer.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupByOptimizer.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/TableSizeBasedBigTableSelectorForAutoSMJ.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/listbucketingpruner/ListBucketingPruner.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrOpProcFactory.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartExprEvalUtils.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/28587/
To: JIRA, sershe
> refactor/clean up partition name pruning to be usable inside metastore server
> ------------------------------------------------------------------------------
>
> Key: HIVE-4985
> URL: https://issues.apache.org/jira/browse/HIVE-4985
> Project: Hive
> Issue Type: Improvement
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-4985.D11961.1.patch
>
>
> Preliminary for HIVE-4914.
> The patch is going to be large already, so some refactoring and dead code
> removal that is non-controversial can be done in advance in a separate patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
