----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11046/#review24628 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java <https://reviews.apache.org/r/11046/#comment48722> is this necessary to create a new instance? metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java <https://reviews.apache.org/r/11046/#comment48721> do you really need to call this in two places? can't you just let the call below take care of things? (fail - relogin - reconnect - succeed). metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java <https://reviews.apache.org/r/11046/#comment48724> minor: checkAndRelogin or similar would say in the name that the method doesn't actually relogin every time. shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java <https://reviews.apache.org/r/11046/#comment48723> can you say hadoop v 20 or use the actual version of the user? or maybe before version 1.0.0. This message sounds like there's still no version that supports it. Same for message below. - Gunther Hagleitner On Aug. 3, 2013, 3 a.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11046/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2013, 3 a.m.) > > > Review request for hive. > > > Bugs: HIVE-4233 > https://issues.apache.org/jira/browse/HIVE-4233 > > > Repository: hive-git > > > Description > ------- > > HIVE-4233- The TGT gotten from class 'CLIService' should be renewed on time > > > Diffs > ----- > > > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java > 76b1989 > shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java c9baa7f > > shims/src/common-secure/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java > 9edcafd > shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java b0f5077 > > Diff: https://reviews.apache.org/r/11046/diff/ > > > Testing > ------- > > manually tested on secure hadoop cluster. > > > Thanks, > > Thejas Nair > >
