[ 
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731448#comment-13731448
 ] 

Gunther Hagleitner commented on HIVE-4579:
------------------------------------------

This is cool. Looks good. A few questions/comments:

- What about [~ehans]'s recommendation? Is it possible to simplify what truth 
values you care about (filters v value-based expr)?

- I think we should open a jira and use the same/similar interface for storage 
handlers. I've gotten requests in the past where ppl are asking for simpler 
structures to be pushed down.

- Can you add comments on how to regenerate the serialized expression trees in 
the test cases? I'm thinking about the case where the serialized data goes 
stale because of changes to the expression tree code. If that happens we might 
have to regen the tests.
                
> Create a SARG interface for RecordReaders
> -----------------------------------------
>
>                 Key: HIVE-4579
>                 URL: https://issues.apache.org/jira/browse/HIVE-4579
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: h-4579.patch, HIVE-4579.D11409.1.patch, pushdown.pdf
>
>
> I think we should create a SARG (http://en.wikipedia.org/wiki/Sargable) 
> interface for RecordReaders. For a first pass, I'll create an API that uses 
> the value stored in hive.io.filter.expr.serialized.
> The desire is to define an simpler interface that the direct AST expression 
> that is provided by hive.io.filter.expr.serialized so that the code to 
> evaluate expressions can be generalized instead of put inside a particular 
> RecordReader.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to