[ 
https://issues.apache.org/jira/browse/HIVE-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733038#comment-13733038
 ] 

Sergey Shelukhin commented on HIVE-4914:
----------------------------------------

https://reviews.apache.org/r/13391/ is the RB link, description from RB is:

Here's the first stab at the patch. It is on top of refactoring from HIVE-4985.
Most of the changes are thrift code.
It unifies get-by-name and get-by-filter methods with new get-by-expr method on 
metastore server side, also merging in the SQL stuff.
On client, the former two are removed and partitions are retrieved via the 
latter.
As described, client only makes one call to the server for partitions, and 
filtering of the names is done on the server side; to that effect, the wrapper 
around PartitionPruner is used.

I will run full test suite overnight.

Some tests have already passed.
                
> filtering via partition name should be done inside metastore server 
> (implementation)
> ------------------------------------------------------------------------------------
>
>                 Key: HIVE-4914
>                 URL: https://issues.apache.org/jira/browse/HIVE-4914
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-4914-only-no-gen.patch, HIVE-4914-only.patch, 
> HIVE-4914.patch
>
>
> Currently, if the filter pushdown is impossible (which is most cases), the 
> client gets all partition names from metastore, filters them, and asks for 
> partitions by names for the filtered set.
> Metastore server code should do that instead; it should check if pushdown is 
> possible and do it if so; otherwise it should do name-based filtering.
> Saves the roundtrip with all partition names from the server to client, and 
> also removes the need to have pushdown viability checking on both sides.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to