[
https://issues.apache.org/jira/browse/HIVE-5003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737235#comment-13737235
]
Gunther Hagleitner commented on HIVE-5003:
------------------------------------------
[~vikram.dixit] Some review comments (RB would be great):
- CANNOT_FIND_EXEC_JAR isn't used/ please remove
- hive.jar.directory should be /user/hive/...
- DagUtils class level javadoc comment is already there (seems you're adding a
second one)
- e.printStackTrace is not good as a debugging method. Either log or pass it on
to the caller
- // java magic isn't a great comment, be good to say what the magic is
achieving
- getResourceVersion comment doesn't match the logic. it will return the
basename not the version string
- There's a system.out.println in the code
> Localize hive exec jar for tez
> ------------------------------
>
> Key: HIVE-5003
> URL: https://issues.apache.org/jira/browse/HIVE-5003
> Project: Hive
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Vikram Dixit K
> Fix For: tez-branch
>
> Attachments: HIVE-5003.1.patch.txt, HIVE-5003.2.patch.txt,
> HIVE-5003.3.patch.txt, HIVE-5003.4.patch.txt, HiveLocalizationDesign.txt
>
>
> Tez doesn't expose a distributed cache. JARs are localized via yarn APIs and
> added to vertices and the dag itself as needed. For hive we need to localize
> the hive-exec.jar.
> NO PRECOMMIT TESTS (this is wip for the tez branch)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
