----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/#review25408 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/BeeLine.java <https://reviews.apache.org/r/11334/#comment49816> I think having this in a function (parseHiveVariables(args) ?) would help in keeping the hive specific code separate beeline/src/java/org/apache/hive/beeline/BeeLine.properties <https://reviews.apache.org/r/11334/#comment49815> beeline is a generic jdbc tool and sqlline does not seem to having much active development. So it would be nice if it easy for people to figure out what parts are hive specific. Can you put this at end of cmd-usage, maybe create a section where any future hive specific parameters can be added ? I think we should make it clear that this gets set as hive config parameter for the connection. What do you think of making this -hiveconf ? (i know it is inconsistent with rest of options). But since this is a hive specific option, we might as well make it consistent with other hive command line tools. That way we can make beeline easily with $HIVE_OPTS also. beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java <https://reviews.apache.org/r/11334/#comment49817> maybe call this hiveConfVars ? beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java <https://reviews.apache.org/r/11334/#comment49818> similar change to names here ? beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java <https://reviews.apache.org/r/11334/#comment49819> separating this into another function will help keep the hive specific code easy to trace. - Thejas Nair On Aug. 21, 2013, 5:42 a.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11334/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2013, 5:42 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-4568 > https://issues.apache.org/jira/browse/HIVE-4568 > > > Repository: hive-git > > > Description > ------- > > 1. Added command variable substition > 2. Added test case > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 4c6eb9b > beeline/src/java/org/apache/hive/beeline/BeeLine.properties b6650cf > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 61bdeee > beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java c70003d > beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java > 030f6b0 > > Diff: https://reviews.apache.org/r/11334/diff/ > > > Testing > ------- > > > Thanks, > > Xuefu Zhang > >
