[ https://issues.apache.org/jira/browse/HIVE-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748190#comment-13748190 ]
Phabricator commented on HIVE-4617: ----------------------------------- thejas has commented on the revision "HIVE-4617 [jira] ExecuteStatementAsync call to run a query in non-blocking mode". Looks like some changes are missing in this patch, can you check those ? (HiveSession ..) INLINE COMMENTS common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:739 hive.server2.async.exec.timeout this is a timeout for how long the HS2 shutdown should wait for the async threads to terminate. The current name is misleading. I think something like hive.server2.async.exec.shutdown.timeout would be more appropriate. conf/hive-default.xml.template:1864 We should state that this is a timeout for how long the HS2 shutdown should wait for the async threads to terminate. Even though the proeprty name has hive-server2 in it, I think it is better to mention HiveServer2 in both descriptions. service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java:147 just the req.setRunAsync is different in these two functions, how about moving this into one function that both call . something like executeStatementInternal(sessionhandle, statemnet, confOverlay, isAsync) REVISION DETAIL https://reviews.facebook.net/D12417 To: JIRA, vaibhavgumashta Cc: thejas > ExecuteStatementAsync call to run a query in non-blocking mode > -------------------------------------------------------------- > > Key: HIVE-4617 > URL: https://issues.apache.org/jira/browse/HIVE-4617 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 > Affects Versions: 0.11.0 > Reporter: Jaideep Dhok > Assignee: Vaibhav Gumashta > Attachments: HIVE-4617.D12417.1.patch, HIVE-4617.D12417.2.patch, > HIVE-4617.D12417.3.patch > > > Provide a way to run a queries asynchronously. Current executeStatement call > blocks until the query run is complete. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira