[
https://issues.apache.org/jira/browse/HIVE-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4914:
------------------------------
Attachment: HIVE-4914.D12561.1.patch
sershe requested code review of "HIVE-4914 [jira] filtering via partition name
should be done inside metastore server (implementation)".
Reviewers: JIRA
Patch without generated code for a better review experience.
Will not build if applied (see previous full patch, I will also attach full
patch after review).
TEST PLAN
ant test
REVISION DETAIL
https://reviews.facebook.net/D12561
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
metastore/if/hive_metastore.thrift
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/30171/
To: JIRA, sershe
> filtering via partition name should be done inside metastore server
> (implementation)
> ------------------------------------------------------------------------------------
>
> Key: HIVE-4914
> URL: https://issues.apache.org/jira/browse/HIVE-4914
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-4914.01.patch, HIVE-4914.D12561.1.patch,
> HIVE-4914-only-no-gen.patch, HIVE-4914-only.patch, HIVE-4914.patch,
> HIVE-4914.patch, HIVE-4914.patch
>
>
> Currently, if the filter pushdown is impossible (which is most cases), the
> client gets all partition names from metastore, filters them, and asks for
> partitions by names for the filtered set.
> Metastore server code should do that instead; it should check if pushdown is
> possible and do it if so; otherwise it should do name-based filtering.
> Saves the roundtrip with all partition names from the server to client, and
> also removes the need to have pushdown viability checking on both sides.
> NO PRECOMMIT TESTS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
