[ 
https://issues.apache.org/jira/browse/HIVE-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-4964:
------------------------------

    Attachment: HIVE-4964.D12585.1.patch

hbutani requested code review of "HIVE-4964 [jira] Cleanup PTF code: remove 
code dealing with non standard sql behavior we had original introduced".

Reviewers: JIRA, ashutoshc

merge with trunk

There are still pieces of code that deal with:

        supporting select expressions with Windowing
        supporting a filter with windowing

Need to do this before introducing  Perf. improvements.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D12585

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java
  ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDesc.java
  ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDeserializer.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/30237/

To: JIRA, ashutoshc, hbutani

                
> Cleanup PTF code: remove code dealing with non standard sql behavior we had 
> original introduced
> -----------------------------------------------------------------------------------------------
>
>                 Key: HIVE-4964
>                 URL: https://issues.apache.org/jira/browse/HIVE-4964
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Harish Butani
>            Priority: Minor
>         Attachments: HIVE-4964.D11985.1.patch, HIVE-4964.D11985.2.patch, 
> HIVE-4964.D12585.1.patch
>
>
> There are still pieces of code that deal with:
> - supporting select expressions with Windowing
> - supporting a filter with windowing
> Need to do this before introducing  Perf. improvements. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to