[ https://issues.apache.org/jira/browse/HIVE-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762272#comment-13762272 ]
Viraj Bhat commented on HIVE-4331: ---------------------------------- Hi Ashutosh and Sushanth, All unit tests corresponding to the Hive's HBaseCliDriver and the (new added tests and old ones) storage handler of HCat pass. I am not sure why the PRE-COMMIT build is showing the following 7 failure/skipped tests for HCat. In fact on my desktop I get no failures for HCat. Most of them are originating in the TestSequenceFileReadWrite TestSequenceFileReadWrite.testSequenceTableWriteRead - test case passes TestSequenceFileReadWrite.testTextTableWriteRead - test cases passes TestSequenceFileReadWrite.testTextTableWriteReadMR - test cases passes TestSequenceFileReadWrite.testSequenceTableWriteReadMR - test case passes TestHCatExternalHCatNonPartitioned.testHCatNonPartitionedTable - test cases passes on my desktop TestHCatStorerMulti.testStoreBasicTable - test case passes TestOrcDynamicPartitioned.testHCatDynamicPartitionedTable - test case passes on my desktop On the Hive there are 2 unit test failures, TestMinimrCliDriver.testCliDriver_smb_mapjoin_8 and TestNegativeCliDriver.testNegativeCliDriver_script_broken_pipe1 which might not be related to this patch. Viraj > Integrated StorageHandler for Hive and HCat using the HiveStorageHandler > ------------------------------------------------------------------------ > > Key: HIVE-4331 > URL: https://issues.apache.org/jira/browse/HIVE-4331 > Project: Hive > Issue Type: Task > Components: HBase Handler, HCatalog > Affects Versions: 0.12.0 > Reporter: Ashutosh Chauhan > Assignee: Viraj Bhat > Fix For: 0.12.0 > > Attachments: HIVE4331_07-17.patch, hive4331hcatrebase.patch, > HIVE-4331.patch, StorageHandlerDesign_HIVE4331.pdf > > > 1) Deprecate the HCatHBaseStorageHandler and "RevisionManager" from HCatalog. > These will now continue to function but internally they will use the > "DefaultStorageHandler" from Hive. They will be removed in future release of > Hive. > 2) Design a HivePassThroughFormat so that any new StorageHandler in Hive will > bypass the HiveOutputFormat. We will use this class in Hive's > "HBaseStorageHandler" instead of the "HiveHBaseTableOutputFormat". > 3) Write new unit tests in the HCat's "storagehandler" so that systems such > as Pig and Map Reduce can use the Hive's "HBaseStorageHandler" instead of the > "HCatHBaseStorageHandler". > 4) Make sure all the old and new unit tests pass without backward > compatibility (except known issues as described in the Design Document). > 5) Replace all instances of the HCat source code, which point to > "HCatStorageHandler" to use the"HiveStorageHandler" including the > "FosterStorageHandler". > I have attached the design document for the same and will attach a patch to > this Jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira