[
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762403#comment-13762403
]
Sushanth Sowmyan commented on HIVE-5112:
----------------------------------------
I noticed two things out-of the ordinary when I tested this:
* Firstly, generated code from serde/if/test/complexpb.proto was not updated.
In general, I noticed other tests fail due to a protobuf jar update, but I
don't see that TestProtocolBuffersObjectInspectors (the associated test with
this .proto) fails, so I guess it's good.
* Second, the protobuf generated code I'm able to generate is
different(descriptorData is different) from the one attached on this patch.
However, tests still pass.
Overall, I'm still +1 on this since tests pass.
> Upgrade protobuf to 2.5 from 2.4
> --------------------------------
>
> Key: HIVE-5112
> URL: https://issues.apache.org/jira/browse/HIVE-5112
> Project: Hive
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Owen O'Malley
> Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch
>
>
> Hadoop and Hbase have both upgraded protobuf. We should as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
