[
https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4844:
------------------------------
Attachment: HIVE-4844.D12891.1.patch
jdere requested code review of "HIVE-4844 [jira] Add varchar data type".
Reviewers: JIRA
Changes to HIVE-4844 per review from ashutosh
Add new varchar data types which have support for more SQL-compliant behavior,
such as SQL string comparison semantics, max length, etc.
Char type will be added as another task.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D12891
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java
common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java
common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java
data/files/datatypes.txt
data/files/vc1.txt
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUpper.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java
ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java
ql/src/test/queries/clientnegative/invalid_varchar_length_1.q
ql/src/test/queries/clientnegative/invalid_varchar_length_2.q
ql/src/test/queries/clientnegative/invalid_varchar_length_3.q
ql/src/test/queries/clientpositive/alter_varchar1.q
ql/src/test/queries/clientpositive/ctas_varchar.q
ql/src/test/queries/clientpositive/partition_varchar1.q
ql/src/test/queries/clientpositive/varchar_1.q
ql/src/test/queries/clientpositive/varchar_2.q
ql/src/test/queries/clientpositive/varchar_cast.q
ql/src/test/queries/clientpositive/varchar_comparison.q
ql/src/test/queries/clientpositive/varchar_join1.q
ql/src/test/queries/clientpositive/varchar_nested_types.q
ql/src/test/queries/clientpositive/varchar_udf1.q
ql/src/test/queries/clientpositive/varchar_union1.q
ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out
ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out
ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out
ql/src/test/results/clientpositive/alter_varchar1.q.out
ql/src/test/results/clientpositive/ctas_varchar.q.out
ql/src/test/results/clientpositive/partition_varchar1.q.out
ql/src/test/results/clientpositive/varchar_1.q.out
ql/src/test/results/clientpositive/varchar_2.q.out
ql/src/test/results/clientpositive/varchar_cast.q.out
ql/src/test/results/clientpositive/varchar_comparison.q.out
ql/src/test/results/clientpositive/varchar_join1.q.out
ql/src/test/results/clientpositive/varchar_nested_types.q.out
ql/src/test/results/clientpositive/varchar_udf1.q.out
ql/src/test/results/clientpositive/varchar_union1.q.out
serde/if/serde.thrift
serde/src/gen/thrift/gen-cpp/serde_constants.cpp
serde/src/gen/thrift/gen-cpp/serde_constants.h
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php
serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
serde/src/gen/thrift/gen-rb/serde_constants.rb
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java
serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java
serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/30861/
To: JIRA, jdere
> Add varchar data type
> ---------------------
>
> Key: HIVE-4844
> URL: https://issues.apache.org/jira/browse/HIVE-4844
> Project: Hive
> Issue Type: New Feature
> Components: Types
> Reporter: Jason Dere
> Assignee: Jason Dere
> Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch,
> HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch,
> HIVE-4844.15.patch, HIVE-4844.16.patch, HIVE-4844.1.patch.hack,
> HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch,
> HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch,
> HIVE-4844.D12699.1.patch, HIVE-4844.D12891.1.patch, screenshot.png
>
>
> Add new varchar data types which have support for more SQL-compliant
> behavior, such as SQL string comparison semantics, max length, etc.
> Char type will be added as another task.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
