[ 
https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767104#comment-13767104
 ] 

Xuefu Zhang commented on HIVE-4844:
-----------------------------------

Also in ParseUtils.getCharParams(), checking NumberFormatException and child 
count is probably not needed. This attributes to the grammar rule.

{code}
+    | KW_VARCHAR LPAREN length=Number RPAREN      ->    ^(TOK_VARCHAR $length)
{code}

This is a minor thing that probably makes the code cleaner.
                
> Add varchar data type
> ---------------------
>
>                 Key: HIVE-4844
>                 URL: https://issues.apache.org/jira/browse/HIVE-4844
>             Project: Hive
>          Issue Type: New Feature
>          Components: Types
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, 
> HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch, 
> HIVE-4844.15.patch, HIVE-4844.16.patch, HIVE-4844.17.patch, 
> HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, 
> HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, 
> HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, 
> HIVE-4844.D12891.1.patch, screenshot.png
>
>
> Add new varchar data types which have support for more SQL-compliant 
> behavior, such as SQL string comparison semantics, max length, etc.
> Char type will be added as another task.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to