[
https://issues.apache.org/jira/browse/HIVE-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hari Sankar Sivarama Subramaniyan updated HIVE-5285:
----------------------------------------------------
Attachment: HIVE-5285.2.patch.txt
The previous upload had an optimization fn hasAllFieldsSettable() which breaks
a couple of tests because the checks are not precise. I am keeping things
simple for now by avoiding any optimizations for creating a new
SettableObjectInspector type. This would ensure correctness in all cases,
however the future scope would be to prevent creating new
SettableObjectInspector object every time we invoke getConvertedOI(). I have
tested the changes with partition_fileformat*.q tests and they pass in my local
machine.
> Custom SerDes throw cast exception when there are complex nested structures
> containing NonSettableObjectInspectors.
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-5285
> URL: https://issues.apache.org/jira/browse/HIVE-5285
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.11.1
> Reporter: Hari Sankar Sivarama Subramaniyan
> Assignee: Hari Sankar Sivarama Subramaniyan
> Priority: Critical
> Attachments: HIVE-5285.1.patch.txt, HIVE-5285.2.patch.txt
>
>
> The approach for HIVE-5199 fix is correct.However, the fix for HIVE-5199 is
> incomplete. Consider a complex nested structure containing the following
> object inspector hierarchy:
> SettableStructObjectInspector
> {
> ListObjectInspector<NonSettableStructObjectInspector>
> }
> In the above case, the cast exception can happen via
> MapOperator/FetchOperator as below:
> java.io.IOException: java.lang.ClassCastException:
> com.skype.data.hadoop.hive.proto.CustomObjectInspector cannot be cast to
> org.apache.hadoop.hive.serde2.objectinspector.SettableMapObjectInspector
> at
> org.apache.hadoop.hive.ql.exec.FetchOperator.getNextRow(FetchOperator.java:545)
> at
> org.apache.hadoop.hive.ql.exec.FetchOperator.pushRow(FetchOperator.java:489)
> at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:136)
> at org.apache.hadoop.hive.ql.Driver.getResults(Driver.java:1412)
> at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:271)
> at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:216)
> at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:413)
> at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:756)
> at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:614)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:160)
> Caused by: java.lang.ClassCastException:
> com.skype.data.whaleshark.hadoop.hive.proto.ProtoMapObjectInspector cannot be
> cast to
> org.apache.hadoop.hive.serde2.objectinspector.SettableMapObjectInspector
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorConverters.getConverter(ObjectInspectorConverters.java:144)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorConverters$StructConverter.<init>(ObjectInspectorConverters.java:294)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorConverters.getConverter(ObjectInspectorConverters.java:138)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorConverters$ListConverter.convert(ObjectInspectorConverters.java:251)
> at
> org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorConverters$StructConverter.convert(ObjectInspectorConverters.java:316)
> at
> org.apache.hadoop.hive.ql.exec.FetchOperator.getNextRow(FetchOperator.java:529)
> ... 13 more
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
