[
https://issues.apache.org/jira/browse/HIVE-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771446#comment-13771446
]
Phabricator commented on HIVE-5209:
-----------------------------------
thejas has commented on the revision "HIVE-5209 [jira] JDBC support for
varchar".
INLINE COMMENTS
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java:57 The focus
of the community has been on hive-server2, I don't think people who have
upgrading to newer versions of hive would use hive-server1 given its
limitations/problems. I don't think we should bother updating the hive-server1
based jdbc code.
service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java:53 This
change does not seem to be necessary, this constructor is using only using type
from the FieldSchema argument.
service/src/java/org/apache/hive/service/cli/TypeQualifiers.java:29 can you
add a comment describing the class ?
service/src/java/org/apache/hive/service/cli/TypeQualifiers.java:24
TypeQualifiers is being used from org/apache/hive/jdbc//HiveQueryResultSet . So
adding a dependency on serde class here would mean that jdbc applications would
also need hive-serde jar. We should avoid that.
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java:36 I think this class
should move out as a top level class in this package.
JdbcColumn seems to be in need of some cleanup, which we can tackle in a
separate jira. Only static functions in it are used. We should move static
functions to a JdbcColumnUtil class and remove the rest of the class.
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java:187 This function isn't
used anywhere, we should remove it.
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java:181 This function isn't
used anywhere, we should remove it.
jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java:32 This import
does not seem to be needed. This classes uses serde classes, I am worried that
using this would lead to a dependency on hive-serde jar as well.
jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java:157
this.columnAttributes.addAll() is missing. Maybe call setSchema() here ?
jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java:240 This is not
used outside, maybe make it private as you are anyway making changes in this
part.
REVISION DETAIL
https://reviews.facebook.net/D12999
To: JIRA, jdere
Cc: cwsteinbach, thejas
> JDBC support for varchar
> ------------------------
>
> Key: HIVE-5209
> URL: https://issues.apache.org/jira/browse/HIVE-5209
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2, JDBC, Types
> Reporter: Jason Dere
> Assignee: Jason Dere
> Attachments: D12999.1.patch, HIVE-5209.1.patch, HIVE-5209.2.patch,
> HIVE-5209.4.patch, HIVE-5209.D12705.1.patch
>
>
> Support returning varchar length in result set metadata
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
