[ https://issues.apache.org/jira/browse/HIVE-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772927#comment-13772927 ]
Hari Sankar Sivarama Subramaniyan commented on HIVE-4773: --------------------------------------------------------- Hi Shuaishuai I have some qns: 1. I am not sure why close() should immediately close if flush() does not perform the same thing.(Eugene' qn) 2. Inside run() of Watcher why do you need to create a new object using PrintWriter writer = new PrintWriter(out); Cant you use 'out' directly instead which will call the corresponding fns depending on the underlying class. Will this not fix the issue ? 3. Even if you add CustomFilterOutputStream class, why do you need to add flush() inside close(). This looks like you are flushing twice. 4. Do you necessarily need to make CustomFilterOutputStream class public. It doesnt look like its used elsewhere. Thanks Hari > Templeton intermittently fail to commit output to file system > ------------------------------------------------------------- > > Key: HIVE-4773 > URL: https://issues.apache.org/jira/browse/HIVE-4773 > Project: Hive > Issue Type: Bug > Components: WebHCat > Reporter: Shuaishuai Nie > Assignee: Shuaishuai Nie > Attachments: HIVE-4773.1.patch, HIVE-4773.2.patch > > > With ASV as a default FS, we saw instances where output is not fully flushed > to storage before the Templeton controller process exits. This results in > stdout and stderr being empty even though the job completed successfully. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira