[ https://issues.apache.org/jira/browse/HIVE-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772960#comment-13772960 ]
Hive QA commented on HIVE-5202: ------------------------------- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12604213/HIVE-5202.patch {color:green}SUCCESS:{color} +1 3129 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/840/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/840/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. > Support for SettableUnionObjectInspector and implement > isSettable/hasAllFieldsSettable APIs for all data types. > --------------------------------------------------------------------------------------------------------------- > > Key: HIVE-5202 > URL: https://issues.apache.org/jira/browse/HIVE-5202 > Project: Hive > Issue Type: Bug > Reporter: Hari Sankar Sivarama Subramaniyan > Assignee: Hari Sankar Sivarama Subramaniyan > Attachments: HIVE-5202.2.patch.txt, HIVE-5202.patch > > > These 3 tasks should be accomplished as part of the following jira: > 1. The current implementation lacks settable union object inspector. We can > run into exception inside ObjectInspectorConverters.getConvertedOI() if there > is a union. > 2. Implement the following public functions for all datatypes: > isSettable()-> Perform shallow check to see if an object inspector is > inherited from settableOI type and > hasAllFieldsSettable() -> Perform deep check to see if this objectInspector > and all the underlying object inspectors are inherited from settableOI type. > 3. ObjectInspectorConverters.getConvertedOI() is inefficient. Once (1) and > (2) are implemented, add the following check: outputOI.hasAllSettableFields() > should be added to return outputOI immediately if the object is entirely > settable in order to prevent redundant object instantiation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira