-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14298/
-----------------------------------------------------------

(Updated Sept. 24, 2013, 5:27 a.m.)


Review request for hive.


Changes
-------

I've re-created a patch for HEAD.


Bugs: HIVE-5296
    https://issues.apache.org/jira/browse/HIVE-5296


Repository: hive-git


Description
-------

Hiveserver2 will occur memory leak caused by increasing Hashtable$Entry at 
least 2 situation as follows.

1. When Exceptions are thrown during executing commmand or query, operation 
handle will not release.
2. Hiveserver2 calls FileSystem#get method and never call FileSystem#close or 
FileSystem.closeAll so FileSystem$Cache will continue to increase.

I've modified HiveSessionImpl and HiveStatement not to lose operation handle. 
Operation handle is needed by OperationManager to remove from handleToOpration.
Also, I've modified HiveSessionImpl to close FileSystem object at the end of 
session.


Diffs (updated)
-----

  jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 2912ece 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
11c96b2 

Diff: https://reviews.apache.org/r/14298/diff/


Testing
-------

I confirmed only not increasing Hashtable$Entry by jmap.


Thanks,

Kousuke Saruta

Reply via email to