[ https://issues.apache.org/jira/browse/HIVE-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13777867#comment-13777867 ]
Hudson commented on HIVE-5274: ------------------------------ FAILURE: Integrated in Hive-trunk-h0.21 #2357 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2357/]) HIVE-5274 : HCatalog package renaming backward compatibility follow-up (Sushanth Sowmyan) (khorgath: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526094) * /hive/trunk/hcatalog/build-support/ant/checkstyle.xml * /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputFormat.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseRevisionManagerUtil.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HbaseSnapshotRecordReader.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ResultConverter.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputFormat.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputFormat.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseHCatStorageHandler.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputFormat.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHCatHBaseInputFormat.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHiveHBaseStorageHandler.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHiveHBaseTableOutputFormat.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestPigHBaseStorageHandler.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestSnapshots.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestZNodeSetUp.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hive/hcatalog * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hive/hcatalog/hbase * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hive/hcatalog/hbase/ManyMiniCluster.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hive/hcatalog/hbase/SkeletonHBaseTest.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hive/hcatalog/hbase/TestHBaseInputFormat.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hive/hcatalog/hbase/TestHiveHBaseStorageHandler.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hive/hcatalog/hbase/TestHiveHBaseTableOutputFormat.java * /hive/trunk/hcatalog/storage-handlers/hbase/src/test/org/apache/hive/hcatalog/hbase/TestPigHBaseStorageHandler.java > HCatalog package renaming backward compatibility follow-up > ---------------------------------------------------------- > > Key: HIVE-5274 > URL: https://issues.apache.org/jira/browse/HIVE-5274 > Project: Hive > Issue Type: Bug > Components: HCatalog > Affects Versions: 0.12.0 > Reporter: Sushanth Sowmyan > Assignee: Sushanth Sowmyan > Fix For: 0.12.0 > > Attachments: HIVE-5274.2.patch, HIVE-5274.3.patch, HIVE-5274.4.patch > > > As part of HIVE-4869, the hbase storage handler in hcat was moved to > org.apache.hive.hcatalog, and then put back to org.apache.hcatalog since it > was intended to be deprecated as well. > However, it imports and uses several org.apache.hive.hcatalog classes. This > needs to be changed to use org.apache.hcatalog classes. > == > Note : The above is a complete description of this issue in and of by itself, > the following is more details on the backward-compatibility goal I have(not > saying that each of these things are violated) : > a) People using org.apache.hcatalog packages should continue being able to > use that package, and see no difference at compile time or runtime. All code > here is considered deprecated, and will be gone by the time hive 0.14 rolls > around. Additionally, org.apache.hcatalog should behave as if it were 0.11 > for all compatibility purposes. > b) People using org.apache.hive.hcatalog packages should never have an > org.apache.hcatalog dependency injected in. > Thus, > It is okay for org.apache.hcatalog to use org.apache.hive.hcatalog packages > internally (say HCatUtil, for example), as long as any interfaces only expose > org.apache.hcatalog.\* For tests that test org.apache.hcatalog.\*, we must be > capable of testing it from a pure org.apache.hcatalog.\* world. > It is never okay for org.apache.hive.hcatalog to use org.apache.hcatalog, > even in tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira