[ 
https://issues.apache.org/jira/browse/HIVE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780027#comment-13780027
 ] 

Eric Hanson commented on HIVE-4642:
-----------------------------------

The cleanest way I've found is to pull hive, git checkout the 'vectorization' 
branch, create a new branch locally for the patch, say teddy/hive-4642, then 
create the patch. When it is done and tested, pull vectorization to make it up 
to date, then merge vectorization into your work branch. Finally, diff the head 
of the two branches. E.g.

git checkout vectorization
git checkout -b teddy/hive-4642
... work ...
git commit -m "..."
git checkout vectorization
git pull vectorization
git checkout teddy/hive-4642
git merge vectorization
git diff vectorization teddy/hive-4642 > HIVE-4642.n-vectorization.patch 
  (where n is a serial number for the patch like 1, 2. 3 ...)

Then upload the patch to the JIRA. The naming convention using n-branch_name in 
the patch name allows the automated tester to try to apply your patch to the 
correct branch. The workflow above makes it likely the patch will apply 
correctly to the vectorization branch.

                
> Implement vectorized RLIKE and REGEXP filter expressions
> --------------------------------------------------------
>
>                 Key: HIVE-4642
>                 URL: https://issues.apache.org/jira/browse/HIVE-4642
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Eric Hanson
>            Assignee: Teddy Choi
>         Attachments: HIVE-4642-1.patch, HIVE-4642.2.patch, 
> HIVE-4642.3.patch.txt, HIVE-4642.4.patch.txt, HIVE-4642.5.patch.txt, 
> HIVE-4642.6.patch.txt, HIVE-4642.7.patch.txt, 
> Hive-Vectorized-Query-Execution-Design-rev10.docx
>
>
> See title. I will add more details next week. The goal is (a) make this work 
> correctly and (b) optimize it as well as possible, at least for the common 
> cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to