[ 
https://issues.apache.org/jira/browse/HIVE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785434#comment-13785434
 ] 

Mark Wagner commented on HIVE-5423:
-----------------------------------

That looks much more friendly to new devs :). I have a couple comments on your 
patch:
* Your patch has the old "SimpleConcatTest" as well as the 
"ExtendedConcatTest". Was that intentional?
* I think ExtendedConcatTest would be better in a package other than 
o.a.h.h.ql.testutil. These new tests should go in o.a.h.h.ql.udf(.generic) like 
other udf tests or their own new package. Maybe just change "testutil" to 
something like o.a.h.h.ql.udf.scalar?


> Speed up testing of scalar UDFS
> -------------------------------
>
>                 Key: HIVE-5423
>                 URL: https://issues.apache.org/jira/browse/HIVE-5423
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>         Attachments: HIVE-5423.1.patch.txt, HIVE-5423.patch.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to